Conversation
Contributor
|
As per the IRC discussion, this seems unlikely to be our issue, since we don't enable the hosts files support on our boxes. Also, probably should use ink_zero() :). |
Member
|
I'm not sure this fixes TS4207 but this is a good patch regardless. +1 from me. |
Contributor
|
Yeah, +1 from me too, but file a new Jira for it since this is likely not related to TS-4207. |
Contributor
Author
|
Yea, once jira is up i'll file one and attach this to it. As for the ink_zero-- I'll add that to the TODO list of my hostdb cleanup. For now this is consistent with the rest of the HostDBInfo clearings. |
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Mar 14, 2016
std::map is creating an entry, and we are setting a subset of values. Since we were not clearing the memory that we got, we end up with some non-initialized structure fields-- meaning the HostDBInfo object we return is corrupt. Fixes apache#523
Contributor
Author
|
Created new Jira, https://issues.apache.org/jira/browse/TS-4272. @zwoop since this is such a simple patch I assume we'll want to backport this? If so, which versions should I port back to? |
std::map is creating an entry, and we are setting a subset of values. Since we were not clearing the memory that we got, we end up with some non-initialized structure fields-- meaning the HostDBInfo object we return is corrupt. Fixes apache#523
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
Propagate variation to autest pipelines so that autest are run on the same variation as the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::map is creating an entry, and we are setting a subset of values. Since we were not clearing the memory that we got, we end up with some non-initialized structure fields-- meaning the HostDBInfo object we return is corrupt.